fix: remove excessive min-height gap in staking product cards#18079
Open
pettinarip wants to merge 1 commit intodevfrom
Open
fix: remove excessive min-height gap in staking product cards#18079pettinarip wants to merge 1 commit intodevfrom
pettinarip wants to merge 1 commit intodevfrom
Conversation
The Chakra→Tailwind migration translated `minHeight={75}` directly to
`min-h-75`, which resolves to ~300px (75 × 0.25rem) and reserved a large
empty gap below the platform/UI badges in every staking product card.
Grid layout already equalizes card heights and `mt-auto` keeps the
footer aligned, so no min-height is needed.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minHeight={75}directly tomin-h-75, which resolves to ~300px (75 × 0.25rem) and reserved a large empty gap below the platform/UI badges in every staking product cardmt-autokeeps the footer aligned, so no min-height is needed on the badges container/staking/solo/,/staking/saas/,/staking/pools/, and the keyGen gridTest plan
/staking/solo/— cards no longer show a large empty gap between the platform/UI badges and the considerations list/staking/saas/and/staking/pools/— cards still align properly across rows