Fix incorrect ordering of row_index/column_index
#4764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xMushow
changed the title
jtraglia
approved these changes
Dec 1, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Nice, good catch! I agree this could be confusing. Thanks for the fix!
jtraglia
changed the title
row_index/column_index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorrect ordering was confusing and can cause clients to implement wrongly the following functions.
According to the structure,
row_indexshould be the 4th parameter:consensus-specs/specs/fulu/das-core.md
Lines 89 to 93 in fe399cf