EIP-7251: Flatten get_active_balance #3949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppopth
force-pushed
the
flatten-get-active-balance
branch
2 times, most recently
from
7b06294 to
fb486c8
Compare
mkalinin
approved these changes
Sep 29, 2024
jtraglia
reviewed
Sep 30, 2024
ralexstokes
approved these changes
Sep 30, 2024
Member
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
weak +1 on Justin's comment, but otherwise love that we are shrinking the spec :)
We have both get_active_balance and get_total_active_balance which have totally different meanings, since get_active_balance uses the balance field while get_total_active_balance uses the effective_balance field. The names suggest that get_total_active_balance is the total of get_active_balance which is not true. The name of get_active_balance doesn't quite make sense and it's used only in one place, so this commit flattens the logic of get_active_balance to the place where it's used.
ppopth
force-pushed
the
flatten-get-active-balance
branch
from
fb486c8 to
cd10274
Compare
jtraglia
approved these changes
Sep 30, 2024
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Looks great. Thanks for making that change 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have both get_active_balance and get_total_active_balance which have totally different meanings, since get_active_balance uses the balance field while get_total_active_balance uses the effective_balance field.
The names suggest that get_total_active_balance is the total of get_active_balance which is not true.
The name of get_active_balance doesn't quite make sense and it's used only in one place, so this commit flattens the logic of get_active_balance to the place where it's used.