Skip to content

EIP-7251: Handle top-ups to exiting/exited validators #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fradamt wants to merge 9 commits into from
+153 −6
Closed

EIP-7251: Handle top-ups to exiting/exited validators #3650

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5ff2bb8
Handle top-ups to exiting/exited validators
fradamt Apr 4, 2024
937c4ef
cache deposits to postpone and append them at the end
fradamt Apr 4, 2024
c4c292d
use withdrawable epoch instead of exit epoch
fradamt Apr 8, 2024
5a94226
add validator definition
fradamt Apr 8, 2024
c9bafcf
add pending_balance_deposits tests for exiting validators
fradamt Apr 9, 2024
0e527bc
fix lint
fradamt Apr 9, 2024
6a5a26f
Fix mutable list bug in tests
hwwhww Apr 11, 2024
6f57389
Merge branch 'dev' into patch-5
fradamt Apr 16, 2024
67ca811
fix lint
fradamt Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions specs/_features/eip7251/beacon-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,12 +588,26 @@ def process_pending_balance_deposits(state: BeaconState) -> None:
available_for_processing = state.deposit_balance_to_consume + get_activation_exit_churn_limit(state)
processed_amount = 0
next_deposit_index = 0
deposits_to_postpone = []

for deposit in state.pending_balance_deposits:
if processed_amount + deposit.amount > available_for_processing:
break
increase_balance(state, deposit.index, deposit.amount)
processed_amount += deposit.amount
# Validator is exiting, postpone the deposit until after withdrawable epoch
if validator.exit_epoch < FAR_FUTURE_EPOCH:
if get_current_epoch(state) <= validator.withdrawable_epoch:
deposits_to_postpone.append(deposit)
# Deposited balance will never become active. Increase balance but do not consume churn
else:
increase_balance(state, deposit.index, deposit.amount)
# Validator is not exiting, attempt to process deposit
else:
# Deposit does not fit in the churn, no more deposit processing in this epoch.
if processed_amount + deposit.amount > available_for_processing:
break
# Deposit fits in the churn, process it. Increase balance and consume churn.
else:
increase_balance(state, deposit.index, deposit.amount)
processed_amount += deposit.amount
# Regardless of how the deposit was handled, we move on in the queue.
next_deposit_index += 1

state.pending_balance_deposits = state.pending_balance_deposits[next_deposit_index:]
Expand All @@ -602,6 +616,8 @@ def process_pending_balance_deposits(state: BeaconState) -> None:
state.deposit_balance_to_consume = 0
else:
state.deposit_balance_to_consume = available_for_processing - processed_amount

state.pending_balance_deposits += deposits_to_postpone
```

#### New `process_pending_consolidations`
Expand Down