Skip to content

Fix dimension of nodeId and remove outdated comment #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hwwhww merged 2 commits into from
Aug 3, 2023
Merged

Fix dimension of nodeId and remove outdated comment #3445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24dc3ec
Fix dimension of nodeId and remove incorrect comment
zilm13 Jul 10, 2023
196744d
Remove debugging
zilm13 Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/core/pyspec/eth2spec/test/phase0/unittests/validator/test_validator_unittest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ def test_get_aggregate_and_proof_signature(spec, state):


def run_compute_subscribed_subnets_arguments(spec, rng=random.Random(1111)):
node_id = rng.randint(0, 2**40 - 1) # try VALIDATOR_REGISTRY_LIMIT
node_id = rng.randint(0, 2**256 - 1)
epoch = rng.randint(0, 2**64 - 1)
subnets = spec.compute_subscribed_subnets(node_id, epoch)
assert len(subnets) == spec.config.SUBNETS_PER_NODE
Expand Down