Skip to content

Conversation

@lightclient
Copy link
Member

adding back since it was removed by mistake.

@lightclient lightclient requested a review from eth-bot as a code owner October 10, 2024 14:21
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Oct 10, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 10, 2024

✅ All reviewers have approved.

@eth-bot eth-bot changed the title 7702: add s value check Update EIP-7702: add s value check Oct 10, 2024
@eth-bot eth-bot enabled auto-merge (squash) October 10, 2024 14:22
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 3e0aee3 into ethereum:master Oct 10, 2024
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have also checked if it was less than or less than or equal to than secp256k1/2. It is the latter. So it is correct :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-update Modifies an existing proposal s-review This EIP is in Review t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants