Update EIP-7702: updates for devnet4 #8929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
Collaborator
|
✅ All reviewers have approved. |
eth-bot
changed the title
Member
etan-status
approved these changes
Oct 4, 2024
3 tasks
lightclient
force-pushed
the
7702-devnet-4
branch
from
a0b6f6f to
7d7f09a
Compare
etan-status
reviewed
Oct 9, 2024
eth-bot
approved these changes
Oct 9, 2024
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
eth-bot
approved these changes
Oct 9, 2024
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
| 7. Add `PER_EMPTY_ACCOUNT_COST - PER_AUTH_BASE_COST` gas to the global refund counter if `authority` exists in the trie. | ||
| 8. Set the code of `authority` to be `0xef0100 || address`. This is a delegation designation. | ||
| 8. Set the code of `authority` to be `0xef0100 || address`. This is a delegation designation. | ||
| * As a special case, if `address` is `0x0000000000000000000000000000000000000000` do not write the designation. Clear the accounts code and reset the account's code hash to `0x0000000000000000000000000000000000000000000000000000000000000000`. |
Member
There was a problem hiding this comment.
Why is the account code hash set to these zeros? It should be set to keccak256("")?
Member
Author
There was a problem hiding this comment.
Ah you're right. Let me update it.
|
|
||
| The `PER_AUTH_BASE_COST` is the cost to process the authorization tuple and set the delegation destination. We are able to compute a fair cost for this operation by reviewing its impact on the system: | ||
|
|
||
| * ferry 101 bytes of calldata = `101 * 16 = 1616` |
Member
There was a problem hiding this comment.
Nit: I see where the 101 comes from (flat bytes of the authority tuple) but this is not super clear. 16 is calldata gas cost for nonzero bytes.
| The `PER_AUTH_BASE_COST` is the cost to process the authorization tuple and set the delegation destination. We are able to compute a fair cost for this operation by reviewing its impact on the system: | ||
|
|
||
| * ferry 101 bytes of calldata = `101 * 16 = 1616` | ||
| * recovering the `authority` address = `3000` |
Member
There was a problem hiding this comment.
Maybe add a note that this is ecrecover precompile cost?
|
|
||
| * ferry 101 bytes of calldata = `101 * 16 = 1616` | ||
| * recovering the `authority` address = `3000` | ||
| * reading the nonce and code of `authority` = `5000` |
Member
There was a problem hiding this comment.
Where does the 5000 cost come from? (If I would check cold extcodecopy I pay 2600 gas, and then nonce can be directly read since we have to read the account RLP (which contains the nonce))
|
|
||
| For most intents and purposes, an account delegated to `0x0` is indistinguishable from a true EOA. However, one particular unfortunate case is unavoidable. Even if a user has a zeroed out delegation designation, most operations that interact with that account will encounter an additional `COLD_ACCOUNT_READ_COST` upon the first touch. | ||
|
|
||
| This is not ideal and may be a significant enough concern to impact the overall adoption of the EIP. For these reasons, we have opted to include a mechanism which allow users to restore their EOA to its original pureness. |
Member
There was a problem hiding this comment.
This is a super great addition 😄 👍
lightclient
changed the title
25 tasks
2 tasks
12 tasks
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Nov 7, 2024
somnergy
pushed a commit
to erigontech/erigon
that referenced
this pull request
Nov 8, 2024
revitteth
pushed a commit
to 0xPolygon/cdk-erigon
that referenced
this pull request
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
placeholder for further devnet changes.
outstanding clarifications to make (from my notes):