Update EIP-1: Add IETF as a permissible origin #7113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
File
|
eth-bot
changed the title
kdenhartog
previously approved these changes
Jun 1, 2023
Contributor
kdenhartog
left a comment
kdenhartog
left a comment
There was a problem hiding this comment.
LGTM thanks for following up on this since I never got back to it. I'll convert mine to focus just on WHATWG since I'm going to what to reference it in EIP-6963
Contributor
|
sounds good 👍 |
Pandapip1
suggested changes
Jun 2, 2023
Member
Pandapip1
left a comment
Pandapip1
left a comment
There was a problem hiding this comment.
Again, I think we should ensure that EIP authors use the right reference (RFC X)
| ^https://github.com/ethereum/devp2p/blob/[0-9a-f]{40}/.*$ | ||
| ``` | ||
|
|
||
| ### Internet Engineering Task Force (IETF) |
Member
There was a problem hiding this comment.
Again, would mildly prefer thr following:
Suggested change
| ### Internet Engineering Task Force (IETF) | |
| ### IETF Request for Comments (RFC) |
9 tasks
streamnft-tech
pushed a commit
to streamnft-tech/EIPs
that referenced
this pull request
Oct 27, 2023
RaphaelHardFork
pushed a commit
to RaphaelHardFork/EIPs
that referenced
this pull request
Jan 30, 2024
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from #6691 by @kdenhartog.
Splitting out so it can be discussed separately.
Changed slightly with my review feedback.