Update EIP-7749: replace incorrect example signature; clarify 0x00 encoding and return format #10791
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coding and return format
github-actions
bot
added
c-update
Collaborator
File
|
|
The commit 691dc60 (as a parent of b103ef9) contains errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example result in EIP-7749 reused the canonical EIP-712 signature which is invalid for ERC-191 0x00, as the preimage and prefix differ; this caused a misleading, non-reproducible example. This change replaces the example signature with a neutral placeholder and adds explicit byte-level encoding rules for the 0x00 scheme, including how to interpret the validator address and data bytes. It also defines the return format precisely as a 65-byte r||s||v signature and clarifies v semantics without EIP-155 chain id for off-chain signing. These updates ensure the example cannot be mistaken for an EIP-712 signature and make the spec implementable and interoperable.