specs: Specify V3 engine API and hardfork version constraint #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trianglesphere
approved these changes
Jan 31, 2024
ImTei
requested review from
ajsutton,
clabby,
maurelian,
mds1,
protolambda and
tynes
as code owners
ImTei
force-pushed
the
engine-api-fork-contraint
branch
from
b8bca0d to
cd6b5ca
Compare
smartcontracts
pushed a commit
that referenced
this pull request
Feb 26, 2025
* feat: add shared lockbox spec (#7) * feat: add shared lockbox spec * feat: update shared lockbox spec * fix: specs * feat: add mermaid diagram * fix: prs comments * fix: nits * fix: remove dependency manager * feat: refactor lockbox specs * fix: nit * fix: misspellings * fix: verb tense * fix: prs comments * fix: small changes * fix: lint * feat: add shared lockbox invariants (#15) * feat: add shared lockbox invariants * fix: remove immutable variable * feat: add upgrader role * feat: add authorized invariants to the portal * fix: pr * fix: add upgrader role and remove new portal invariants * feat: dependency set refactor (#19) * feat: dependency set refactor * fix: pr * feat: add new shared lockbox specs * fix: remove interop naming * fix: extension * fix: summary * fix: dependency manager descope (#22) * feat: ETH lockbox redesign * fix: add proxy admin owner check * fix: pr fixes * fix: authorize portal fixes * fix: authorize lockbox fix * fix: add unlockETH invariant and adminOwner getter * fix: add migrate liquidity invariant * fix: pr fixes * fix: invariant rewording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please refer ethereum-optimism/optimism#9253
newPayloadV3,forkchoiceUpdatedV3andgetPayloadV3must return Unsupported fork error if they are called before Cancun.So added specified constraints that V3 engine apis must be called with Ecotone payloads.