Skip to content

Conversation

@ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Feb 4, 2024

Description

Skip TestOutputCannonStepWithLargePreimage until we can fix the flakiness. The batcher seems to be able to create a transaction below the minimum large preimage size sometimes.

Metadata

@ajsutton ajsutton requested a review from a team as a code owner February 4, 2024 23:32
@ajsutton ajsutton requested a review from Inphi February 4, 2024 23:32
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2024

Walkthrough

Walkthrough

The modification involves adding a skip directive to a test function within a specific test file. This action was taken to address an issue of test flakiness, indicating that the test sometimes fails under certain conditions. The directive includes a message highlighting the need for further investigation and resolution of the underlying problem causing the flakiness.

Changes

File Path Change Summary
.../output_cannon_test.go Added a skip directive to TestOutputCannonStepWithLargePreimage with a message about flakiness needing investigation.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@ajsutton ajsutton requested a review from mslipper February 4, 2024 23:34
@codecov
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ed50c4) 27.85% compared to head (702b12f) 62.56%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #9341       +/-   ##
============================================
+ Coverage    27.85%   62.56%   +34.70%     
============================================
  Files          167       16      -151     
  Lines         7362     1445     -5917     
  Branches      1272        0     -1272     
============================================
- Hits          2051      904     -1147     
+ Misses        5190      495     -4695     
+ Partials       121       46       -75     
Flag Coverage Δ
cannon-go-tests 62.56% <ø> (ø)
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 151 files with indirect coverage changes

@mslipper mslipper added this pull request to the merge queue Feb 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2024
@ajsutton ajsutton added this pull request to the merge queue Feb 5, 2024
Merged via the queue into develop with commit afb2048 Feb 5, 2024
@ajsutton ajsutton deleted the aj/disable-large-preimage-test branch February 5, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants