Load Alloc For Superchain ops integration testing #14021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14021 +/- ##
===========================================
- Coverage 46.86% 45.33% -1.54%
===========================================
Files 974 917 -57
Lines 81666 76998 -4668
Branches 759 759
===========================================
- Hits 38275 34906 -3369
+ Misses 40406 39330 -1076
+ Partials 2985 2762 -223
Flags with carried forward coverage won't be shown. Click here to find out more. |
blmalone
changed the title
maurelian
approved these changes
Jan 28, 2025
Contributor
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
A couple questions, but overall LGTM
mds1
approved these changes
Jan 28, 2025
Contributor
mds1
left a comment
mds1
left a comment
There was a problem hiding this comment.
LGTM aside from the comment clarifications above
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
…14021) * fix: test * fix: nit checking to see if adding a new env causes the issue. * fix: unused var * fix: adding branhing logic * fix: copying other pr * fix: clarifications around comments.
QuentinI
pushed a commit
to EspressoSystems/optimism-espresso-integration
that referenced
this pull request
Mar 7, 2025
…14021) * fix: test * fix: nit checking to see if adding a new env causes the issue. * fix: unused var * fix: adding branhing logic * fix: copying other pr * fix: clarifications around comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of this PR #14007. For an unknown reason I could not get CI to pass on the original PR. I copied the code over and it started work. I tried saving the commit history but kept running into the same issues.
This was an external contribition by @ElliotFriedman and @prateek105.
cc: