Skip to content

[BUG]: Decimal locales not properly checked #114

@ethan-hann

Description

@ethan-hann

Contact Details

No response

What happened?

In locales with a different decimal separator (like Germany, where decimals use commas [3,14159] and large numbers use dots [9.999.999] ), the station naming kinda breaks down.
Number conversion is handled automatically for different locales, but the conversion to strings doesn't account for changing it back to US locale.

The input boxes are properly localized, so the FM number input in this example display 98,4. The automatic conversion to the text name breaks down though.

First, the auto-check always inserts a space before the decimal separator. Then, probably due to the inserted space, any change made to the FM selector will lead to run-on numbers.

Cycling the FM numbers from 98.1 to 98.2 to 98.3 to 98.4 for example will result in a station name of:
"98 ,4 ,3 ,2 ,1 StationName"
Since it keeps reinserting the decimal before the space.
You can't manually fix it either, since the tool always auto-"corrects" when you finish input.

The game itself doesn't seem to care much, since the German localization wildly mixes dots and commas for default radio stations, but i don't know how radioExt handles the folders and station names, especially with the additional space in there. I haven't tried yet.

Expected Behavior

The tool should properly convert between decimal locale sperators.

Relevant log output

Additional Info and Screenshots

No response

Version

2.0.447

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions