p2p: add --use-proxy flag for SOCKS5 proxy support #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds SOCKS5 proxy support for peer-to-peer connections in the Ethereum client. It introduces a new --use-proxy command-line flag that enables routing peer connections through a SOCKS5 proxy configured via the ALL_PROXY or all_proxy environment variables.
Key Changes:
- Added
UseProxyconfiguration field to enable proxy usage - Enhanced
tcpDialerto support proxy connections with context cancellation - Integrated new CLI flag into the geth application
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| p2p/server.go | Added UseProxy config field and updated tcpDialer initialization to pass the proxy flag |
| p2p/dial.go | Modified tcpDialer struct to support proxy dialing with context cancellation handling |
| cmd/utils/flags.go | Added UseProxyFlag CLI flag and integrated it into SetP2PConfig |
| cmd/geth/main.go | Added UseProxyFlag to the application's networking flags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cloorc
force-pushed
the
feature/proxy
branch
2 times, most recently
from
a428e99 to
9c9c6e0
Compare
Add support for routing P2P connections through a SOCKS5 proxy specified via ALL_PROXY or all_proxy environment variables. This enables nodes to connect to peers through proxy servers when needed. Key changes: - Add --use-proxy CLI flag to enable proxy detection - Implement proxy dialing with context cancellation support - Add debug logging to track proxy usage - Prevent goroutine leaks on context cancellation The implementation uses golang.org/x/net/proxy.FromEnvironment() which detects SOCKS5 proxies from ALL_PROXY/all_proxy environment variables. Signed-off-by: Cloorc <[email protected]> Signed-off-by: cloorc <[email protected]>
cloorc
force-pushed
the
feature/proxy
branch
from
9c9c6e0 to
4cf1f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for routing P2P connections through a SOCKS5 proxy specified via ALL_PROXY or all_proxy environment variables. This enables nodes to connect to peers through proxy servers when needed.
Key changes:
The implementation uses golang.org/x/net/proxy.FromEnvironment() which detects SOCKS5 proxies from ALL_PROXY/all_proxy environment variables.
This PR will fix #686