[3.4] backport client: call .Endpoints() in dial() in client/v3/client.go instead of accessing cfg.Endpoints directly #16857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accessing cfg.Endpoints directly https://github.com/etcd-io/etcd/blob/0cdd558361c6bdbbd9e4023558e2f6ece71c18ad/client/v3/client.go#L299 accesses endpoints without acquiring lock. Fix it to call Endpoints() Fix etcd-io#13201 Signed-off-by: Chao Chen <[email protected]>
chaochn47
force-pushed
the
release-3.4-atomic-endpoints
branch
from
de5cc66 to
055b6d7
Compare
Member
Author
chaochn47
force-pushed
the
release-3.4-atomic-endpoints
branch
from
3561cf3 to
471225d
Compare
Signed-off-by: Chao Chen <[email protected]>
chaochn47
force-pushed
the
release-3.4-atomic-endpoints
branch
from
471225d to
97a6f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breakdown of #16827 for #16740
Backports
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.