Skip to content

Conversation

@ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 18, 2022

Command:

trivy image --severity CRITICAL gcr.io/etcd-development/etcd:v3.5.6 

See report:
Screen Shot 2022-12-19 at 07 52 44

Signed-off-by: Benjamin Wang [email protected]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

cc @mitake @ptabor @serathius @spzala

@ahrtr ahrtr added area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 18, 2022
@ahrtr
Copy link
Member Author

ahrtr commented Dec 18, 2022

Note: I have confirmed that there is no critical Vulnerabilities any more after using the distroless base image.

@ahrtr ahrtr changed the title security: use distroless base image to address critical Vulnerabilities Security: use distroless base image to address critical Vulnerabilities Dec 18, 2022
Command:
trivy image --severity CRITICAL gcr.io/etcd-development/etcd:v3.5.6 -f json -o 3.5.6_image_critical.json

Signed-off-by: Benjamin Wang <[email protected]>
@ahrtr ahrtr force-pushed the use_distroless_3.5_20221219 branch from d38d450 to b766840 Compare December 18, 2022 23:59
@ahrtr ahrtr changed the title Security: use distroless base image to address critical Vulnerabilities [3.5] Security: use distroless base image to address critical Vulnerabilities Dec 19, 2022
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(non-binding)

Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention it in a changelog.

It's a potentially breaking change (if someone installs own scripts on top of etcd image).

@ahrtr
Copy link
Member Author

ahrtr commented Dec 19, 2022

Please mention it in a changelog.

Yes, I will update the changelog when I finish all the Vulnerabilities (including HIGH and critical)

@ahrtr
Copy link
Member Author

ahrtr commented Dec 19, 2022

Thanks both @ptabor and @fuweid

@ahrtr ahrtr merged commit 4e03851 into etcd-io:release-3.5 Dec 19, 2022
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
[3.5] Security: use distroless base image to address critical Vulnerabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Development

Successfully merging this pull request may close these issues.

3 participants