Skip to content

Update dep: github.com/golang/protobuf v1.3.5 ->  v1.5.1, grpc: 1.32->1.36 #12801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 24, 2021
Merged

Update dep: github.com/golang/protobuf v1.3.5 ->  v1.5.1, grpc: 1.32->1.36 #12801

merged 5 commits into from
Mar 24, 2021

Conversation

@ptabor
Copy link
Contributor

@ptabor ptabor commented Mar 24, 2021 •
edited
Loading

Thanks to https://go-review.googlesource.com/c/protobuf/+/300869/ its feasible now.

Huge kudos to: @dsnet and @justinsb

ptabor added 2 commits March 24, 2021 20:40
@ptabor
test.sh: Temporarilly disable the "eeshew you" fmt check.
62d3ede
@ptabor
codec.go: should use google runtime
7d7a9c6 
golang-proto runtime can deal with both: gogo & golang generated
protobufs. It does not work vice-versa with protobuf-1.5.1.
@ptabor ptabor force-pushed the 20210323-try-upgrade-proto branch from d85ca9b to be59f98 Compare March 24, 2021 21:07
@ptabor ptabor force-pushed the 20210323-try-upgrade-proto branch from be59f98 to 0dabcb4 Compare March 24, 2021 21:28
gyuho
gyuho approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks x100!

@ptabor ptabor changed the title Update dep: github.com/golang/protobuf v1.3.5 ->  v1.5.1 Update dep: github.com/golang/protobuf v1.3.5 ->  v1.5.1, grpc: 1.32->1.36 Mar 24, 2021
@ptabor ptabor force-pushed the 20210323-try-upgrade-proto branch from 0dabcb4 to d0962f1 Compare March 24, 2021 22:31
@ptabor ptabor merged commit 65d6a1f into etcd-io:master Mar 24, 2021
@ptabor ptabor deleted the 20210323-try-upgrade-proto branch March 24, 2021 22:57
@ptabor ptabor mentioned this pull request Mar 24, 2021
Merged
16 tasks
@chaochn47 chaochn47 mentioned this pull request Oct 13, 2023
Closed
24 tasks
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Nov 22, 2023
@chaochn47
backport etcd-io#12709 and etcd-io#12801 to resolve gogo unmarshal er…
f549da3 
…rors

Signed-off-by: Chao Chen <[email protected]>
@ahrtr ahrtr mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gyuho gyuho gyuho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ptabor @gyuho