Skip to content

Conversation

@YoyinZyc
Copy link
Contributor

@YoyinZyc YoyinZyc commented Feb 3, 2020

added changelog for #11574

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #11582 into master will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11582      +/-   ##
==========================================
- Coverage   64.68%   64.16%   -0.53%     
==========================================
  Files         403      403              
  Lines       38074    38074              
==========================================
- Hits        24628    24429     -199     
- Misses      11809    12013     +204     
+ Partials     1637     1632       -5
Impacted Files Coverage Δ
client/keys.go 70.35% <0%> (-21.11%) ⬇️
pkg/transport/timeout_conn.go 80% <0%> (-20%) ⬇️
auth/store.go 50.76% <0%> (-17.86%) ⬇️
etcdserver/api/v3rpc/util.go 51.61% <0%> (-16.13%) ⬇️
auth/simple_token.go 86.99% <0%> (ø) ⬆️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
clientv3/txn.go 100% <0%> (ø) ⬆️
clientv3/leasing/util.go 91.66% <0%> (-6.67%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
pkg/fileutil/purge.go 66% <0%> (-6%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a698ad6...05a0e36. Read the comment docs.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spzala spzala merged commit 3ad2b67 into etcd-io:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants