fix: aws registry encryptionConfiguration to be applied#827
Merged
Conversation
Owner
|
@almoelda Can you check the tests? |
Contributor
Author
|
@estahn Apologies for that. I've added the new default of EncryptionType ( |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 28.04% 27.79% -0.26%
==========================================
Files 11 11
Lines 1041 1054 +13
==========================================
+ Hits 292 293 +1
- Misses 724 736 +12
Partials 25 25 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the CreateRepositoryInput structure for ECR registry according to the configuration.
Added the a default value for the EncryptionType and validation for the KmsKey key.
fixes #598