feat(zigbee): Allow setting mode after Zigbee has started#12308
feat(zigbee): Allow setting mode after Zigbee has started#12308P-R-O-C-H-Y wants to merge 1 commit into
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 90 files 90 suites 34m 7s ⏱️ Results for commit 504914e. |
Description of Change
This pull request updates the
setModemethod inZigbeeWindowCoveringto improve how the window covering mode attribute is set, handling both cases when Zigbee is started and when it is not.Improvements to attribute setting logic:
setModeinZigbeeWindowCovering.cppto useesp_zb_zcl_set_attribute_valwith proper locking when Zigbee is started, and to fall back to updating the attribute directly when Zigbee is not started, including enhanced error handling and logging in both cases.Test Scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)
Related links