Skip to content

feat: consolidate samoyed and samoyed-hook into unified binary architecture #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behrangsa merged 6 commits into from
Aug 4, 2025
Merged

feat: consolidate samoyed and samoyed-hook into unified binary architecture #81

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed5295a
feat: consolidate samoyed and samoyed-hook into unified binary archit…
behrangsa Aug 3, 2025
52067b3
refactor: remove duplicate config structures, use existing config module
behrangsa Aug 4, 2025
df9bef8
refactor: extract deprecation date to constant in hook_runner.rs
behrangsa Aug 4, 2025
551983e
test: improve coverage for hook command and deprecation shim
behrangsa Aug 4, 2025
d73c68c
feat: complete binary consolidation with updated documentation
behrangsa Aug 4, 2025
b9207fc
test: add comprehensive coverage for logging module functions
behrangsa Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
689 changes: 36 additions & 653 deletions src/hook_runner.rs
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions src/hooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ pub fn create_hook_directory(fs: &dyn FileSystem, hooks_dir: &Path) -> Result<()
/// Creates all standard Git hook files
///
/// This function creates a hook file for each standard Git hook. Each hook
/// file is a simple shell script that delegates to the `samoyed-hook` binary
/// runner. All hook files are made executable (mode 0755).
/// file is a simple shell script that delegates to the `samoyed hook` command.
/// All hook files are made executable (mode 0755).
///
/// # Arguments
///
Expand All @@ -168,13 +168,13 @@ pub fn create_hook_directory(fs: &dyn FileSystem, hooks_dir: &Path) -> Result<()
/// Each hook file contains:
/// ```bash
/// #!/usr/bin/env sh
/// exec samoyed-hook "$(basename "$0")" "$@"
/// exec samoyed hook "$(basename "$0")" "$@"
/// ```
///
/// This delegates to the `samoyed-hook` binary, passing the hook name and all arguments.
/// This delegates to the `samoyed hook` command, passing the hook name and all arguments.
pub fn create_hook_files(fs: &dyn FileSystem, hooks_dir: &Path) -> Result<(), HookError> {
let hook_content = r#"#!/usr/bin/env sh
exec samoyed-hook "$(basename "$0")" "$@""#;
exec samoyed hook "$(basename "$0")" "$@""#;

// Normalize line endings to LF for cross-platform compatibility
let normalized_content = normalize_line_endings(hook_content);
Expand Down
2 changes: 2 additions & 0 deletions src/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ use crate::project::ProjectType;
/// * `runner` - Command runner for executing system commands
/// * `fs` - Filesystem abstraction for file operations
/// * `project_type_hint` - Optional project type hint (e.g., "rust", "node")
/// * `force` - Optional force regeneration parameter (e.g., "_" to force hook regeneration)
///
/// # Returns
///
Expand All @@ -43,6 +44,7 @@ pub fn init_command(
runner: &dyn CommandRunner,
fs: &dyn FileSystem,
project_type_hint: Option<String>,
_force: Option<String>,
) -> Result<()> {
// Check if we're in a Git repository
if !fs.exists(Path::new(".git")) {
Expand Down
Loading
Loading