Skip to content

Conversation

@antonello-contini-one
Copy link

@antonello-contini-one antonello-contini-one commented Jan 20, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

Please provide a clear and concise description of your changes, including the motivation behind these changes. The context is crucial for the reviewers.

Testing

Describe how you tested your changes.

@bugadani
Copy link
Contributor

Given that RS485 is half-duplex, and our UART driver is full-duplex, I'm not convinced this is how we want to support RS485. Please mark all public APIs you are introducing with #[instability::unstable] for now so that we can revisit.

@MabezDev
Copy link
Member

MabezDev commented May 8, 2025

Closing this for now, please feel free to open a new PR with the review comments resolved.

@MabezDev MabezDev closed this May 8, 2025
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Jul 15, 2025
@i404788 i404788 mentioned this pull request Jul 15, 2025
6 tasks
i404788 pushed a commit to i404788/esp-hal that referenced this pull request Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants