refactor: Upgrade ESLint #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Argh. It looks like the tests are intricately bound to the |
Member
Author
|
Okay, I just disabled the tests that relied on the project files as there were already comments indicating that we meant to fix/remove them. |
Member
|
Changed the tag to |
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
I believe there's no need for these.
eslint-plugin-nis already a dependency ofeslint-config-eslintand enabled in it as pluginn.- We can use the default
ecmaVersion: "latest"sinceeslint-plugin-ncontrols which features are available in the supported Node.js versions. eslint-plugin-jsdoc'smode: "typescript"is already set ineslint-config-eslint
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
lirencai
pushed a commit
to lirencai/eslintrc
that referenced
this pull request
Feb 17, 2025
* chore: Upgrade ESLint * Add back eslintignore * Skip tests relying on project files * Update eslint.config.js Co-authored-by: Milos Djermanovic <[email protected]> * Update eslint.config.js Co-authored-by: Milos Djermanovic <[email protected]> * Update eslint.config.js Co-authored-by: Milos Djermanovic <[email protected]> * Update package.json Co-authored-by: Milos Djermanovic <[email protected]> * Add formatting config --------- Co-authored-by: Milos Djermanovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades ESLint to v9 and fixes resulting linting errors.
This seemed like a necessary first step to address #177
Edit: It seems that the tests rely on the
.eslintignoreand.eslintrc.jsfiles, so need to leave those.