Skip to content

Conversation

@BenjaminHoegh
Copy link

This pull request updates the project's PHP version compatibility, development dependencies, and coding standards configuration to align with modern practices and PHP 8.2. The most important changes include upgrading to PHP 8.2, updating development dependencies, and adopting newer coding standards.

PHP Version and Dependency Updates:

  • Updated the required PHP version in composer.json from ^7.1||^8.0 to ^8.2, ensuring compatibility with PHP 8.2.
  • Updated development dependencies in composer.json to newer versions:
    • phpunit/phpunit to ^11.5
    • vimeo/psalm to ^6.12
    • friendsofphp/php-cs-fixer to ^3.82
    • infection/infection to ^0.29
    • roave/infection-static-analysis-plugin to ^1.38

Coding Standards Configuration:

  • Updated .php-cs-fixer.dist.php to use the @PSR12 coding standard instead of @PSR2 and added the @PHP82Migration rule set for modern PHP syntax. Removed several rules to simplify the configuration, such as no_unused_imports and ordered_imports. as theses are in PSR12 already

Copilot AI review requested due to automatic review settings July 10, 2025 08:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project to require PHP 8.2, upgrades development tooling versions, and modernizes the coding standards configuration.

  • Bump PHP requirement from ^7.1||^8.0 to ^8.2 and update dev dependencies (phpunit, psalm, php-cs-fixer, infection, etc.).
  • Switch .php-cs-fixer.dist.php rules from PSR2 to PSR12 with the @PHP82Migration set and remove redundant rules.
  • Disable PhpCsFixer cache explicitly via setUsingCache(false).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
composer.json Updated PHP version constraint and refreshed dev dependencies
.php-cs-fixer.dist.php Switched to @PSR12 & @PHP82Migration, removed some rules, and disabled cache
Comments suppressed due to low confidence (2)

.php-cs-fixer.dist.php:15

  • [nitpick] The removal of the single‐line closure allowance under the braces rule means single‐line closures will now be disallowed; please confirm this matches your intended coding style or reintroduce the rule if needed.
    ],

.php-cs-fixer.dist.php:31

  • Disabling the cache in PhpCsFixer can slow down repeated runs; consider enabling the cache (or removing this setting) to improve performance during local and CI runs.
    ->setUsingCache(false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant