Add support to specific route in express#18
Merged
Conversation
A new option was added that allows to use a specific route with the middleware provided by staticify. This option is used by the getVersionedPath method. The specified route for the middleware is added before the versioned path. When a specific route is not used, the method continues to function normally. Ref issue #15
The description and example of the new specific route option was added in the README file.
Collaborator
|
@tojacob: can you add tests? |
Contributor
Author
|
@XhmikosR: |
Member
|
LGTM! Thanks for the PR, @tojacob. I know this is bikeshedding, but is |
This was referenced Jun 15, 2018
Closed
Collaborator
|
Note that this should be squashed into one commit when merging. |
Contributor
Author
|
@rakeshpai: It's true, I have serious problems with names. @XhmikosR: Okay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 🙂
I added a new option that allows to use the integrated middleware through a specific route in express.
In the issue #15 had proposed a solution, but after reviewing the code calmly, I realized that the problem was only in the method that returns the versioned path:
getVersionedPath.It happens because when adding a route for the middleware, the method
getVersionedPathhas no knowledge of it, and continues to return the direct path.With the new option it is possible to specify that the middleware will pass through a route.
The new option is used in the
getVersionedPathmethod. In this way, it returns the path correctly even when there is a specific route for the middleware.Example of use:
I await your comments. 👍
Fixes #15