polygon/sync: implement header downloader#9030
Merged
Conversation
taratorio
changed the title
taratorio
commented
Dec 19, 2023
| } | ||
| } | ||
|
|
||
| type BlockDownloader struct { |
Member
Author
There was a problem hiding this comment.
pending unit tests: wip
battlmonstr
force-pushed
the
pr/astrid_sync
branch
from
d7a1d18 to
0463fca
Compare
battlmonstr
approved these changes
Dec 20, 2023
battlmonstr
reviewed
Dec 20, 2023
…strid-download-blocks
taratorio
changed the title
taratorio
commented
Dec 21, 2023
| peers := hd.choosePeers(allPeers, statePoints) | ||
| if len(peers) == 0 { | ||
| hd.logger.Warn( | ||
| fmt.Sprintf("[%s] can't use any peers to sync, will try again", headerDownloaderLogPrefix), |
Member
Author
There was a problem hiding this comment.
@battlmonstr if this ever happens, ie we have all 100 max peers but all are not synced enough (highly unlikely I suppose but possible) we can add a sentry function to temporarily disconnect them for some time interval so we can connect to others that may be synced further ahead - what do you think? would a disconnect be the same as penalize in this case or penalized means we will never connect to the penalized peer again in the future?
Member
Author
There was a problem hiding this comment.
work for a future PR regardless
taratorio
commented
Dec 21, 2023
|
|
||
| import "github.com/ledgerwatch/erigon/core/types" | ||
|
|
||
| type HeaderVerifier func(statePoint *statePoint, headers []*types.Header) error |
Member
Author
There was a problem hiding this comment.
will implement in subsequent PR
mh0lt
approved these changes
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.