Skip to content

Add Context getters and setters for ZMQ_IO_THREADS #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

Add Context getters and setters for ZMQ_IO_THREADS #311

merged 1 commit into from
Jul 30, 2020

Conversation

@kalcutter
Copy link
Contributor

@kalcutter kalcutter commented Jul 10, 2020

Fixes #206

Specific getters and setters are used following the precedence from Socket.

@kalcutter
Copy link
Contributor Author

kalcutter commented Jul 10, 2020

I did not adhere to RFC #344 regarding getters for consistency with the Socket API. Let me know if I should change the getter name to io_threads.

@erickt erickt merged commit eede431 into erickt:master Jul 30, 2020
@erickt
Copy link
Owner

erickt commented Jul 30, 2020

Thanks! Yeah, I think it's better to follow the convention of the library, rather than following RFC #344.

@kalcutter kalcutter deleted the context-io-threads branch July 31, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow creation with more than default IO threads

2 participants

@kalcutter @erickt