Skip to content

Conversation

@erhant
Copy link
Owner

@erhant erhant commented Apr 15, 2024

@numtel can we decrease the number of hardhat libs added as dev dependency? do we really need all of them?

@erhant
Copy link
Owner Author

erhant commented Apr 15, 2024

for example, do we really need typechain if we do ts-ignore anyways?

@numtel
Copy link
Contributor

numtel commented Apr 15, 2024

Good point, those were just what hardhat told me to install on the project init. I had removed the other files it generated but it very well could lose some of these dependencies. I'll take a look tonight and see which ones are required.

@numtel
Copy link
Contributor

numtel commented Apr 15, 2024

Well, it actually looks like hardhat will not run without the dependencies.

Running the tests with just hardhat and @nomicfoundation/hardhat-ethers gives me:

Error: Cannot find module '@nomicfoundation/hardhat-toolbox'

But if I just add that one package, it requests all the rest.

HardhatError: HH801: Plugin @nomicfoundation/hardhat-toolbox requires the following dependencies to be installed: @nomicfoundation/hardhat-chai-matchers, @nomicfoundation/hardhat-ignition-ethers, @nomicfoundation/hardhat-network-helpers, @nomicfoundation/hardhat-verify, @typechain/ethers-v6, @typechain/hardhat, hardhat-gas-reporter, solidity-coverage, typechain.

As far as using a different EVM test environment, Ganache could theoretically do the job with fewer dependencies but it's deprecated. Using hardhat seems simpler than integrating Foundry since that's not just an NPM install.

@erhant
Copy link
Owner Author

erhant commented Apr 15, 2024

ah alright, thanks for investigating it 🙏🏻

@erhant erhant merged commit 9612a1b into main Apr 15, 2024
@erhant erhant deleted the erhant/hardhat-concise branch May 14, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent >1 optimization for PLONK

3 participants