-
Notifications
You must be signed in to change notification settings - Fork 44
fix: Fixed string type logs not being rendered #2440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Anders2303
merged 2 commits into
equinor:master
from
Anders2303:well-log-viewer/fix-string-valuetype
Feb 13, 2025
Merged
fix: Fixed string type logs not being rendered #2440
Anders2303
merged 2 commits into
equinor:master
from
Anders2303:well-log-viewer/fix-string-valuetype
Feb 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1nklr
approved these changes
Feb 13, 2025
Collaborator
|
Are the color changes in the images expected ? |
Collaborator
Author
Yes 👍
|
hkfb
pushed a commit
that referenced
this pull request
Feb 13, 2025
## [2.3.2](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@2.3.2) (2025-02-13) ### Bug Fixes * Fixed string type logs not being rendered ([#2440](#2440)) ([90acb69](90acb69))
Collaborator
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
HansKallekleiv
pushed a commit
to HansKallekleiv/webviz-subsurface-components
that referenced
this pull request
Oct 23, 2025
## [0.6.4](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.6.4) (2024-05-29) ### Bug Fixes * bump ajv from 8.12.0 to 8.14.0 in /typescript ([equinor#2075](equinor#2075)) ([e7194a4](equinor@e7194a4)), closes [ajv-validator/ajv#2424](ajv-validator/ajv#2424) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [ajv-validator/ajv#2428](ajv-validator/ajv#2428) [ajv-validator/ajv#2431](ajv-validator/ajv#2431) [equinor#2427](equinor#2427) [ajv-validator/ajv#2433](ajv-validator/ajv#2433) [ajv-validator/ajv#2440](ajv-validator/ajv#2440) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [equinor#2440](equinor#2440) [equinor#2427](equinor#2427) [equinor#2433](equinor#2433) [equinor#2431](equinor#2431) [equinor#2428](equinor#2428) [equinor#2410](equinor#2410) [equinor#2424](equinor#2424) [equinor#2423](equinor#2423) [equinor#2421](equinor#2421) [equinor#2406](equinor#2406) [equinor#2402](equinor#2402)
HansKallekleiv
pushed a commit
to HansKallekleiv/webviz-subsurface-components
that referenced
this pull request
Oct 23, 2025
## [1.2.16](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.2.16) (2024-05-29) ### Bug Fixes * bump ajv from 8.12.0 to 8.14.0 in /typescript ([equinor#2075](equinor#2075)) ([e7194a4](equinor@e7194a4)), closes [ajv-validator/ajv#2424](ajv-validator/ajv#2424) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [ajv-validator/ajv#2428](ajv-validator/ajv#2428) [ajv-validator/ajv#2431](ajv-validator/ajv#2431) [equinor#2427](equinor#2427) [ajv-validator/ajv#2433](ajv-validator/ajv#2433) [ajv-validator/ajv#2440](ajv-validator/ajv#2440) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [equinor#2440](equinor#2440) [equinor#2427](equinor#2427) [equinor#2433](equinor#2433) [equinor#2431](equinor#2431) [equinor#2428](equinor#2428) [equinor#2410](equinor#2410) [equinor#2424](equinor#2424) [equinor#2423](equinor#2423) [equinor#2421](equinor#2421) [equinor#2406](equinor#2406) [equinor#2402](equinor#2402)
HansKallekleiv
pushed a commit
to HansKallekleiv/webviz-subsurface-components
that referenced
this pull request
Oct 23, 2025
## [0.27.2](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.27.2) (2024-05-29) ### Bug Fixes * bump ajv from 8.12.0 to 8.14.0 in /typescript ([equinor#2075](equinor#2075)) ([e7194a4](equinor@e7194a4)), closes [ajv-validator/ajv#2424](ajv-validator/ajv#2424) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [ajv-validator/ajv#2428](ajv-validator/ajv#2428) [ajv-validator/ajv#2431](ajv-validator/ajv#2431) [equinor#2427](equinor#2427) [ajv-validator/ajv#2433](ajv-validator/ajv#2433) [ajv-validator/ajv#2440](ajv-validator/ajv#2440) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [equinor#2440](equinor#2440) [equinor#2427](equinor#2427) [equinor#2433](equinor#2433) [equinor#2431](equinor#2431) [equinor#2428](equinor#2428) [equinor#2410](equinor#2410) [equinor#2424](equinor#2424) [equinor#2423](equinor#2423) [equinor#2421](equinor#2421) [equinor#2406](equinor#2406) [equinor#2402](equinor#2402)
HansKallekleiv
pushed a commit
to HansKallekleiv/webviz-subsurface-components
that referenced
this pull request
Oct 23, 2025
## [1.1.16](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.1.16) (2024-05-29) ### Bug Fixes * bump ajv from 8.12.0 to 8.14.0 in /typescript ([equinor#2075](equinor#2075)) ([e7194a4](equinor@e7194a4)), closes [ajv-validator/ajv#2424](ajv-validator/ajv#2424) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [ajv-validator/ajv#2428](ajv-validator/ajv#2428) [ajv-validator/ajv#2431](ajv-validator/ajv#2431) [equinor#2427](equinor#2427) [ajv-validator/ajv#2433](ajv-validator/ajv#2433) [ajv-validator/ajv#2440](ajv-validator/ajv#2440) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [equinor#2440](equinor#2440) [equinor#2427](equinor#2427) [equinor#2433](equinor#2433) [equinor#2431](equinor#2431) [equinor#2428](equinor#2428) [equinor#2410](equinor#2410) [equinor#2424](equinor#2424) [equinor#2423](equinor#2423) [equinor#2421](equinor#2421) [equinor#2406](equinor#2406) [equinor#2402](equinor#2402)
HansKallekleiv
pushed a commit
to HansKallekleiv/webviz-subsurface-components
that referenced
this pull request
Oct 23, 2025
## [1.8.1](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@1.8.1) (2024-05-29) ### Bug Fixes * bump ajv from 8.12.0 to 8.14.0 in /typescript ([equinor#2075](equinor#2075)) ([e7194a4](equinor@e7194a4)), closes [ajv-validator/ajv#2424](ajv-validator/ajv#2424) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [ajv-validator/ajv#2428](ajv-validator/ajv#2428) [ajv-validator/ajv#2431](ajv-validator/ajv#2431) [equinor#2427](equinor#2427) [ajv-validator/ajv#2433](ajv-validator/ajv#2433) [ajv-validator/ajv#2440](ajv-validator/ajv#2440) [ajv-validator/ajv#2410](ajv-validator/ajv#2410) [equinor#2440](equinor#2440) [equinor#2427](equinor#2427) [equinor#2433](equinor#2433) [equinor#2431](equinor#2431) [equinor#2428](equinor#2428) [equinor#2410](equinor#2410) [equinor#2424](equinor#2424) [equinor#2423](equinor#2423) [equinor#2421](equinor#2421) [equinor#2406](equinor#2406) [equinor#2402](equinor#2402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tracks.ts/setupPlothad an error that caused all curvesvaluetype: "string"to be skipped. Fixed it so that stacked curves once again support string values. Also updated the "Discrete" storybook example to include a string-value curve, so that future smoke-tests can notice this type of error.I also tweaked some internals in tracks.ts while I was at it; renamed some internal functions and variables, and made sure that styles are applied before
setupPlotis called (this is to ensure we have the full props when validating them). Note: a side-effect of this is thatgenerateColor()is called a little more often, so the smoke-tests screenshots have been updated to accommodate for new colors