This repository was archived by the owner on Mar 14, 2025. It is now read-only.
Move installation of komodo-shims to the end#554
Merged
berland merged 1 commit intoequinor:mainfrom Feb 25, 2025
Merged
Conversation
berland
force-pushed
the
komodo_shims_late_install
branch
from
2a29a16 to
80319ae
Compare
The previous approach would only possibly work if komodo-shims was a pypi package. It is not. With this commit, it is installed in a separate and new section in the build process, and is installed directly from its downloaded source location.
berland
force-pushed
the
komodo_shims_late_install
branch
from
80319ae to
5ca3a99
Compare
andreas-el
approved these changes
Feb 25, 2025
Collaborator
andreas-el
left a comment
andreas-el
left a comment
There was a problem hiding this comment.
Let's do this! We can kick a new bleeding build immediately to verify. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach would only possibly work if komodo-shims was a pypi package. It will not be. With this commit, it is installed in a separate and new section, and is installed directly from its downloaded source location.