[Backport version-19.0] Avoid race condition for multiple everest monitors#12817
Merged
berland merged 1 commit intoversion-19.0from Feb 6, 2026
Merged
[Backport version-19.0] Avoid race condition for multiple everest monitors#12817berland merged 1 commit intoversion-19.0from
berland merged 1 commit intoversion-19.0from
Conversation
If several monitors (each is a subscriber) are attached to an everest
server, the server could crash with a RuntimeError when tearing down;
Traceback (most recent call last):
File "/data/projects/ert/src/ert/dark_storage/endpoints/experiment_server.py", line 341, in run
for sub in shared_data.subscribers.values():
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: dictionary changed size during iteration
This is because there is an await in the loop execution body, which
allows the async loop to add a new subscriber while we are iterating.
By expanding the values() iterator to a fixed list before looping, we
avoid the possibility of a race condition (but we are leaving behind the
possible late added subscriber)
Repeated testing with multiple monitors with this patch has not
revealed any further issues.
(cherry picked from commit 2870c3c)
9 tasks
berland
approved these changes
Feb 6, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## version-19.0 #12817 +/- ##
=============================================
Coverage 90.54% 90.54%
=============================================
Files 437 437
Lines 30098 30098
=============================================
Hits 27251 27251
Misses 2847 2847
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
berland
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #12814 to
version-19.0.