Limit capturing of warnings from forward model steps#12789
Limit capturing of warnings from forward model steps#12789berland merged 2 commits intoequinor:mainfrom
Conversation
Leaving this uncapped can give an arbitrary amount of log messages, which will be useless the user seeing this in the GUI, and will also clog the logging system.
berland
added
the
release-notes:maintenance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12789 +/- ##
==========================================
+ Coverage 90.68% 90.72% +0.03%
==========================================
Files 433 434 +1
Lines 30239 30249 +10
==========================================
+ Hits 27422 27443 +21
+ Misses 2817 2806 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| real: Realization, | ||
| job_submission_time: float, | ||
| timeout_seconds: int = Job.DEFAULT_FILE_VERIFICATION_TIMEOUT, | ||
| max_logged_warnings: int = 200, |
There was a problem hiding this comment.
Do you think this will be high enough? Since this is the sum of all warnings, others might be overlooked. This is per realization?
There was a problem hiding this comment.
This is up for discussion. 200 is not very much, agree, but still more than what the user is able to take in when these are flashed in the GUI.
Some warnings will for sure be overlooked, and then will be missing in our logging system if we search for specific warnings, but that will be the case for any picked number.
There was a problem hiding this comment.
Would it be a bad idea to log a certain message every time we hit this cap?
|
Successfully created backport PR for |
3 participants
Leaving this uncapped can give an arbitrary amount of log messages, which will be useless the user seeing this in the GUI, and will also clog the logging system.
Issue
Resolves #12781
Approach
⛔
git rebase -i main --exec 'just rapid-tests')When applicable