Skip to content

Revert fix private ip address#12778

Merged
jonathan-eq merged 2 commits intoequinor:version-19.0from
jonathan-eq:fix-private-ip-address
Feb 3, 2026
Merged

Revert fix private ip address#12778
jonathan-eq merged 2 commits intoequinor:version-19.0from
jonathan-eq:fix-private-ip-address

Conversation

@jonathan-eq
Copy link
Copy Markdown
Contributor

@jonathan-eq jonathan-eq commented Feb 3, 2026

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq self-assigned this Feb 3, 2026
@jonathan-eq jonathan-eq added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Feb 3, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.54%. Comparing base (4b7dc2c) to head (8ee996e).

Files with missing lines Patch % Lines
src/ert/shared/net_utils.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-19.0   #12778      +/-   ##
================================================
- Coverage         90.55%   90.54%   -0.02%     
================================================
  Files               437      437              
  Lines             30112    30088      -24     
================================================
- Hits              27267    27242      -25     
- Misses             2845     2846       +1     
Flag Coverage Δ
cli-tests 37.15% <68.75%> (-0.05%) ⬇️
gui-tests 68.60% <12.50%> (-0.01%) ⬇️
performance-and-unit-tests 76.82% <81.25%> (-0.02%) ⬇️
test 37.95% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathan-eq jonathan-eq enabled auto-merge (rebase) February 3, 2026 14:19
@jonathan-eq jonathan-eq merged commit 74264d2 into equinor:version-19.0 Feb 3, 2026
35 checks passed
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing jonathan-eq:fix-private-ip-address (8ee996e) with version-19.0 (4b7dc2c)

Summary

✅ 23 untouched benchmarks

@jonathan-eq jonathan-eq deleted the fix-private-ip-address branch February 25, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:bug-fix Automatically categorise as bug fix in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants