Skip to content

Add suppression for Performance warning for fetching of misfit data in storage_info_widget#12774

Merged
SAKavli merged 2 commits intoequinor:mainfrom
SAKavli:add-warning-suppression
Feb 3, 2026
Merged

Add suppression for Performance warning for fetching of misfit data in storage_info_widget#12774
SAKavli merged 2 commits intoequinor:mainfrom
SAKavli:add-warning-suppression

Conversation

@SAKavli
Copy link
Copy Markdown
Contributor

@SAKavli SAKavli commented Feb 3, 2026

Issue
Resolves #12773

I tested this on TGX to double check that the warnings disappeared.
We discussed that this might not warrant a test, especially because the endpoint in "LibresFacade" is to be deprecated at some point.

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@SAKavli SAKavli added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Feb 3, 2026
@SAKavli SAKavli changed the title Add warning suppression Add suppression for Performance warning for fetching of misfit data in storage_info_widget Feb 3, 2026
In large examples such as Drogon, we experience warnings being
displayed to users in the terminal when calling upon the
`load_all_misfit_data` method from LibresFacade.

This will ignore those warnings to avoid them being printed in the
terminal.
@SAKavli SAKavli force-pushed the add-warning-suppression branch from 557a9e8 to 072a5c9 Compare February 3, 2026 11:48
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.66%. Comparing base (5a17c55) to head (072a5c9).

Files with missing lines Patch % Lines
...ui/tools/manage_experiments/storage_info_widget.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12774      +/-   ##
==========================================
- Coverage   90.67%   90.66%   -0.02%     
==========================================
  Files         433      433              
  Lines       30184    30188       +4     
==========================================
- Hits        27370    27369       -1     
- Misses       2814     2819       +5     
Flag Coverage Δ
cli-tests 37.16% <0.00%> (-0.01%) ⬇️
gui-tests 68.57% <66.66%> (+<0.01%) ⬆️
performance-and-unit-tests 77.04% <66.66%> (-0.02%) ⬇️
test 37.47% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing SAKavli:add-warning-suppression (072a5c9) with main (5a17c55)

Summary

✅ 23 untouched benchmarks

Copy link
Copy Markdown
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SAKavli SAKavli merged commit ee41291 into equinor:main Feb 3, 2026
36 checks passed
@scout-team-app
Copy link
Copy Markdown

scout-team-app Bot commented Feb 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport version-19.0 release-notes:bug-fix Automatically categorise as bug fix in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warnings shown in terminal when opening export misfit tab in large projects

3 participants