Add localization columns to obs and responses endpoint#12730
Conversation
RFT observations have "north" and "east" as primary keys. Dropping these before merging dataframes causes Ert to crash. This will prevent dropping keys which overlap localization keys.
a0264eb to
b4529d7
Compare
|
Does this call for another test, or should the edited tests be coverage enough for this behavior? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12730 +/- ##
==========================================
- Coverage 90.65% 90.65% -0.01%
==========================================
Files 432 432
Lines 30168 30175 +7
==========================================
+ Hits 27349 27354 +5
- Misses 2819 2821 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b4529d7 to
49eaeae
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
|
One comment. Have you double checked whether the observations are actually in the field? |
|
If it is a bug-fix maybe it should contain the backport label to current testing? |
49eaeae to
108bd0a
Compare
108bd0a to
82eae6f
Compare
|
Thanks for the feedback, Julius! We decided to leave all test data to None for localization columns, as these values should make sense with the dimensions of the respective field. @xjules will test this in another PR and find some appropriate values for localization. This should definitely be backported to February release - thanks! |
|
Successfully created backport PR for |
Issue
Resolves #12631
git rebase -i main --exec 'just rapid-tests')When applicable