Skip to content

Vectorize parameter sampling#12648

Merged
lucaeg merged 5 commits intomainfrom
vectorize-sample-prior
Jan 21, 2026
Merged

Vectorize parameter sampling#12648
lucaeg merged 5 commits intomainfrom
vectorize-sample-prior

Conversation

@lucaeg
Copy link
Contributor

@lucaeg lucaeg commented Jan 15, 2026

Vectorize the sampling rather than drawing one value at a time. This cosmetic change makes the code cleaner and easier to understand. In our view, drawing all samples for a parameter simultaneously is more natural and better aligned with standard sampling APIs (e.g., scipy).

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@lucaeg lucaeg requested a review from oyvindeide January 15, 2026 12:50
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (0ac0ce1) to head (32f7f1c).
⚠️ Report is 13 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12648      +/-   ##
==========================================
- Coverage   90.66%   90.63%   -0.03%     
==========================================
  Files         429      431       +2     
  Lines       29802    30065     +263     
==========================================
+ Hits        27019    27250     +231     
- Misses       2783     2815      +32     
Flag Coverage Δ
cli-tests 37.33% <100.00%> (-0.24%) ⬇️
gui-tests 68.69% <100.00%> (-0.69%) ⬇️
performance-and-unit-tests 74.04% <100.00%> (+0.11%) ⬆️
test 37.58% <7.69%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing vectorize-sample-prior (32f7f1c) with main (6995ffc)

Summary

✅ 22 untouched benchmarks

@lucaeg lucaeg added this to SCOUT Jan 16, 2026
@lucaeg lucaeg moved this to Ready for Review in SCOUT Jan 16, 2026
Copy link
Contributor

@achaikou achaikou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry to crash the party uninvited, but I was out of stuff to do 😊

I am also missing some context in the commit description about the reason for the change (is there some problem to be solved or would code just look nicer?), so I have to guess 😄

Copy link
Contributor

@achaikou achaikou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right to assume that all those commits would be squashed?
I am just more accustomed to the fixup commit style 🙂

Btw, I am happy with the changes, but I don't feel like an ert-adult yet to click the "Approve" button for this PR 😄

@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Jan 20, 2026
@lucaeg lucaeg merged commit 053ebb7 into main Jan 21, 2026
38 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Jan 21, 2026
@lucaeg lucaeg deleted the vectorize-sample-prior branch January 21, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants