Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12648 +/- ##
==========================================
- Coverage 90.66% 90.63% -0.03%
==========================================
Files 429 431 +2
Lines 29802 30065 +263
==========================================
+ Hits 27019 27250 +231
- Misses 2783 2815 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
achaikou
left a comment
There was a problem hiding this comment.
I am sorry to crash the party uninvited, but I was out of stuff to do 😊
I am also missing some context in the commit description about the reason for the change (is there some problem to be solved or would code just look nicer?), so I have to guess 😄
achaikou
left a comment
There was a problem hiding this comment.
Am I right to assume that all those commits would be squashed?
I am just more accustomed to the fixup commit style 🙂
Btw, I am happy with the changes, but I don't feel like an ert-adult yet to click the "Approve" button for this PR 😄
Vectorize the sampling rather than drawing one value at a time. This cosmetic change makes the code cleaner and easier to understand. In our view, drawing all samples for a parameter simultaneously is more natural and better aligned with standard sampling APIs (e.g., scipy).
git rebase -i main --exec 'just rapid-tests')When applicable