Skip to content

Add possibility to read rft observations from csv file#12628

Merged
HakonSohoel merged 5 commits intomainfrom
read-rft-obs-from-csv-file
Jan 14, 2026
Merged

Add possibility to read rft observations from csv file#12628
HakonSohoel merged 5 commits intomainfrom
read-rft-obs-from-csv-file

Conversation

@HakonSohoel
Copy link
Contributor

@HakonSohoel HakonSohoel commented Jan 13, 2026

Approach
Introduce the possibility to read rft observations as a csv file.
The csv file is on the same format currently in use with the GENDATA_RFT forward model.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@HakonSohoel HakonSohoel self-assigned this Jan 13, 2026
@HakonSohoel HakonSohoel moved this to Ready for Review in SCOUT Jan 13, 2026
@HakonSohoel HakonSohoel added the release-notes:new-feature Automatically categorise as new feature in release notes label Jan 13, 2026
@eivindjahren eivindjahren requested a review from Copilot January 13, 2026 09:20
When RFT_OBSERVATION is used a CSV file can be specified to read
multiple observations.
@HakonSohoel HakonSohoel force-pushed the read-rft-obs-from-csv-file branch from 4ad682a to 23b6e4d Compare January 13, 2026 09:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.53%. Comparing base (87e6aa7) to head (acddbb9).
⚠️ Report is 13 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12628      +/-   ##
==========================================
- Coverage   90.54%   90.53%   -0.01%     
==========================================
  Files         435      434       -1     
  Lines       30014    30038      +24     
==========================================
+ Hits        27175    27195      +20     
- Misses       2839     2843       +4     
Flag Coverage Δ
cli-tests 37.40% <37.03%> (+0.13%) ⬆️
gui-tests 68.90% <51.85%> (+0.19%) ⬆️
performance-and-unit-tests 73.92% <100.00%> (+0.03%) ⬆️
test 38.03% <25.92%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing read-rft-obs-from-csv-file (acddbb9) with main (67f7ea4)

Summary

✅ 22 untouched benchmarks

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a look at whether any of the copilot suggestions make sense to apply, otherwise I have no comments.

@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Jan 13, 2026
@HakonSohoel HakonSohoel enabled auto-merge (squash) January 14, 2026 09:14
@HakonSohoel HakonSohoel merged commit 52a5ea9 into main Jan 14, 2026
37 checks passed
@HakonSohoel HakonSohoel deleted the read-rft-obs-from-csv-file branch January 14, 2026 09:19
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Jan 14, 2026
berland pushed a commit to berland/ert that referenced this pull request Jan 14, 2026
* Add option to read rft observations from csv file

When RFT_OBSERVATION is used a CSV file can be specified to read
multiple observations.
lucaeg pushed a commit to lucaeg/ert that referenced this pull request Jan 14, 2026
* Add option to read rft observations from csv file

When RFT_OBSERVATION is used a CSV file can be specified to read
multiple observations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:new-feature Automatically categorise as new feature in release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants