Fix small issues in everest docs#12598
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12598 +/- ##
==========================================
- Coverage 90.56% 90.52% -0.04%
==========================================
Files 435 435
Lines 29977 30014 +37
==========================================
+ Hits 27148 27171 +23
- Misses 2829 2843 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
83f4206 to
04ad43a
Compare
04ad43a to
047743d
Compare
047743d to
c9d50c8
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
|
Even though Equinor officially should write British English, we are possibly beyond the point where we can change back from optimization to optimization, as for realization - (realization has become the de-facto FMU standard). I don't know if TNO has any preference for british vs americal English. |
f482d56 to
7f625f2
Compare
|
I thought it was a good idea to improve the docs while I went through it, but perhaps I've caused enough ruccus and should leave it as is more or less, before something breaks. |
|
I'd say use "optimization" everywhere for consistency, and keep your other fixes, they are valuable! |
2a515f9 to
0896c14
Compare
|
Squash all or selectively? |
|
Most commits touch the same lines - as they were huge, aka merge conflicts. Squashing all would save that headache. Can keep newlines as a separate commit to make the grammatical changes more readable. |
0896c14 to
99bd0c5
Compare
An -> A data assimilation Consistently write realization Replace model definition "ensemble of models" with "ensemble of realiations" Take away -> takeaways Consistently captialize Everest in text Use optimize with z consistently
99bd0c5 to
018361a
Compare
Am reading the documentation, so I will fix any issues I find along the way.
This will be squashed.