Skip to content

Create copy all messages button in Suggestor#12588

Merged
SAKavli merged 2 commits intoequinor:mainfrom
SAKavli:implement-copy-all-button
Jan 9, 2026
Merged

Create copy all messages button in Suggestor#12588
SAKavli merged 2 commits intoequinor:mainfrom
SAKavli:implement-copy-all-button

Conversation

@SAKavli
Copy link
Contributor

@SAKavli SAKavli commented Jan 7, 2026

Resolves specific request from user on slack.

My first iterations consisted of a class method which I wanted to insert among the other buttons, hence the refactoring of the other buttons. That refactoring was strictly not necessary for the final code, but I still believe it is an improvement, so I decided to keep it.

Screen.Recording.2026-01-08.at.16.03.10.mov

This pull request implements a "Copy all messages" button in the Suggestor widget, allowing users to copy all error, warning, and deprecation messages to the clipboard with a single click.

Key Changes:

Added a new _CopyAllButton class that extends CopyButton to copy all messages at once
Refactored the action buttons layout to accommodate the new copy all button alongside existing close/continue buttons
Added comprehensive tests to verify the copy all functionality works correctly across different message types

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@SAKavli SAKavli added this to SCOUT Jan 7, 2026
@SAKavli SAKavli self-assigned this Jan 7, 2026
@SAKavli SAKavli moved this to In Progress in SCOUT Jan 7, 2026
@SAKavli SAKavli force-pushed the implement-copy-all-button branch from 8df3a64 to dac880e Compare January 7, 2026 09:19
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.53%. Comparing base (2a0015b) to head (69dae97).
⚠️ Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12588      +/-   ##
==========================================
- Coverage   90.58%   90.53%   -0.05%     
==========================================
  Files         435      435              
  Lines       29929    30036     +107     
==========================================
+ Hits        27110    27192      +82     
- Misses       2819     2844      +25     
Flag Coverage Δ
cli-tests 37.33% <0.00%> (-0.03%) ⬇️
gui-tests 68.61% <94.59%> (-0.07%) ⬇️
performance-and-unit-tests 73.90% <100.00%> (-0.04%) ⬇️
test 38.04% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SAKavli SAKavli force-pushed the implement-copy-all-button branch 2 times, most recently from 1542432 to f83e20f Compare January 7, 2026 13:20
@SAKavli SAKavli requested a review from Copilot January 7, 2026 13:21
@SAKavli SAKavli changed the title Implement copy all button in Suggestor Add copy all messages button in Suggestor Jan 7, 2026
@SAKavli SAKavli added the release-notes:new-feature Automatically categorise as new feature in release notes label Jan 7, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements a "Copy all messages" button in the Suggestor widget, allowing users to copy all error, warning, and deprecation messages to the clipboard with a single click.

Key Changes:

  • Added a new _CopyAllButton class that extends CopyButton to copy all messages at once
  • Refactored the action buttons layout to accommodate the new copy all button alongside existing close/continue buttons
  • Added comprehensive tests to verify the copy all functionality works correctly across different message types

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
tests/ert/unit_tests/gui/test_suggestor.py Adds tests for the copy all button functionality, verifying it correctly copies errors, warnings, and deprecations with consistent whitespace formatting
src/ert/gui/ertwidgets/suggestor/suggestor.py Implements the _CopyAllButton class and refactors the action button layout to include the new copy all button when messages are present

@SAKavli SAKavli force-pushed the implement-copy-all-button branch 2 times, most recently from 4f13a0d to a0c38a6 Compare January 7, 2026 14:10
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 7, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing SAKavli:implement-copy-all-button (69dae97) with main (c7dae2d)

Summary

✅ 22 untouched benchmarks

@SAKavli SAKavli moved this from In Progress to Ready for Review in SCOUT Jan 7, 2026
@SAKavli SAKavli changed the title Add copy all messages button in Suggestor Create copy all messages button in Suggestor Jan 7, 2026
@SAKavli SAKavli force-pushed the implement-copy-all-button branch 5 times, most recently from 3cbe669 to 8eee25c Compare January 8, 2026 15:22
@SAKavli SAKavli requested a review from Copilot January 8, 2026 15:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@SAKavli SAKavli force-pushed the implement-copy-all-button branch from 8eee25c to a69631c Compare January 8, 2026 15:31
@SAKavli SAKavli force-pushed the implement-copy-all-button branch from a69631c to 69dae97 Compare January 8, 2026 15:32
Copy link
Contributor

@HakonSohoel HakonSohoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Jan 9, 2026
@SAKavli SAKavli merged commit acbd663 into equinor:main Jan 9, 2026
35 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:new-feature Automatically categorise as new feature in release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants