Create copy all messages button in Suggestor#12588
Conversation
8df3a64 to
dac880e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12588 +/- ##
==========================================
- Coverage 90.58% 90.53% -0.05%
==========================================
Files 435 435
Lines 29929 30036 +107
==========================================
+ Hits 27110 27192 +82
- Misses 2819 2844 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1542432 to
f83e20f
Compare
There was a problem hiding this comment.
Pull request overview
This pull request implements a "Copy all messages" button in the Suggestor widget, allowing users to copy all error, warning, and deprecation messages to the clipboard with a single click.
Key Changes:
- Added a new
_CopyAllButtonclass that extendsCopyButtonto copy all messages at once - Refactored the action buttons layout to accommodate the new copy all button alongside existing close/continue buttons
- Added comprehensive tests to verify the copy all functionality works correctly across different message types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
tests/ert/unit_tests/gui/test_suggestor.py |
Adds tests for the copy all button functionality, verifying it correctly copies errors, warnings, and deprecations with consistent whitespace formatting |
src/ert/gui/ertwidgets/suggestor/suggestor.py |
Implements the _CopyAllButton class and refactors the action button layout to include the new copy all button when messages are present |
4f13a0d to
a0c38a6
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
3cbe669 to
8eee25c
Compare
8eee25c to
a69631c
Compare
a69631c to
69dae97
Compare
Resolves specific request from user on slack.
My first iterations consisted of a class method which I wanted to insert among the other buttons, hence the refactoring of the other buttons. That refactoring was strictly not necessary for the final code, but I still believe it is an improvement, so I decided to keep it.
Screen.Recording.2026-01-08.at.16.03.10.mov
This pull request implements a "Copy all messages" button in the Suggestor widget, allowing users to copy all error, warning, and deprecation messages to the clipboard with a single click.
Key Changes:
Added a new _CopyAllButton class that extends CopyButton to copy all messages at once
Refactored the action buttons layout to accommodate the new copy all button alongside existing close/continue buttons
Added comprehensive tests to verify the copy all functionality works correctly across different message types
git rebase -i main --exec 'just rapid-tests')When applicable