Skip to content

Improve error message on invalid key:value format#12586

Merged
berland merged 1 commit intoequinor:mainfrom
berland:improve_configvalidationerror_on_dicts
Jan 8, 2026
Merged

Improve error message on invalid key:value format#12586
berland merged 1 commit intoequinor:mainfrom
berland:improve_configvalidationerror_on_dicts

Conversation

@berland
Copy link
Contributor

@berland berland commented Jan 6, 2026

Issue
Resolves #12585

Approach
Rewrite text and adapt tests.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@berland berland added the release-notes:improvement Automatically categorise as improvement in release notes label Jan 6, 2026
@berland berland self-assigned this Jan 6, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.56%. Comparing base (7bdb6d2) to head (7bee21b).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12586      +/-   ##
==========================================
- Coverage   90.58%   90.56%   -0.02%     
==========================================
  Files         435      435              
  Lines       29931    29933       +2     
==========================================
- Hits        27112    27110       -2     
- Misses       2819     2823       +4     
Flag Coverage Δ
cli-tests 37.35% <ø> (-0.01%) ⬇️
gui-tests 68.66% <ø> (+0.01%) ⬆️
performance-and-unit-tests 73.92% <ø> (-0.02%) ⬇️
test 38.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 6, 2026

CodSpeed Performance Report

Merging #12586 will not alter performance

Comparing berland:improve_configvalidationerror_on_dicts (7bee21b) with main (e212883)

Summary

✅ 22 untouched

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@berland berland merged commit e767160 into equinor:main Jan 8, 2026
36 checks passed
@berland berland deleted the improve_configvalidationerror_on_dicts branch March 6, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:improvement Automatically categorise as improvement in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor user experience with optional arguments in config

3 participants