Remove Webviz ERT and BaseService#12567
Merged
yngve-sk merged 8 commits intoequinor:mainfrom Jan 14, 2026
Merged
Conversation
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
from
0b02fd9 to
0b0d56d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12567 +/- ##
==========================================
+ Coverage 90.54% 90.64% +0.09%
==========================================
Files 434 429 -5
Lines 30022 29779 -243
==========================================
- Hits 27183 26992 -191
+ Misses 2839 2787 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
2 times, most recently
from
1278c0c to
ed69bd1
Compare
yngve-sk
added
blocked
release-notes:breaking-change
yngve-sk
commented
Jan 6, 2026
yngve-sk
commented
Jan 6, 2026
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
3 times, most recently
from
375fc69 to
372392b
Compare
berland
reviewed
Jan 12, 2026
src/ert/services/__init__.py
Outdated
| from .webviz_ert_service import WebvizErt | ||
|
|
||
| __all__ = ["BaseServiceExit", "ErtServer", "ServerBootFail", "WebvizErt"] | ||
| __all__ = ["BaseServiceExit", "ErtServer", "ServerBootFail"] |
Contributor
There was a problem hiding this comment.
BaseServiceExit should probably be renamed to ErtServerExit in this PR.
berland
reviewed
Jan 12, 2026
| @@ -1,204 +0,0 @@ | |||
| """ | |||
Contributor
There was a problem hiding this comment.
is this file removed, or just emptied in this PR? (it looks emptied, I would suppose it should be removed)
Contributor
Author
There was a problem hiding this comment.
Was not, removed it now
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
from
372392b to
0dc66d9
Compare
Should not be hardcoded to 120
For clarity and easier testing, prefer singleton global string var over in-place hardcoding of strings.
To not lose test coverage when removing BaseService
yngve-sk
force-pushed
the
26.01.remove-baseservice
branch
from
0dc66d9 to
a5ec8af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PS: Should consider when to merge this in wrt deprecation warnings etc.