Skip to content

Add timeouts to run_dialog integration tests#12548

Merged
jonathan-eq merged 1 commit intoequinor:mainfrom
jonathan-eq:add-timeouts
Dec 29, 2025
Merged

Add timeouts to run_dialog integration tests#12548
jonathan-eq merged 1 commit intoequinor:mainfrom
jonathan-eq:add-timeouts

Conversation

@jonathan-eq
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (89e570e) to head (4819aa8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12548      +/-   ##
==========================================
- Coverage   90.68%   90.66%   -0.03%     
==========================================
  Files         431      431              
  Lines       29734    29734              
==========================================
- Hits        26965    26959       -6     
- Misses       2769     2775       +6     
Flag Coverage Δ
cli-tests 37.62% <ø> (ø)
gui-tests 68.75% <ø> (+0.03%) ⬆️
performance-and-unit-tests 74.17% <ø> (-0.03%) ⬇️
test 38.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 23, 2025

CodSpeed Performance Report

Merging #12548 will not alter performance

Comparing jonathan-eq:add-timeouts (4819aa8) with main (89e570e)

Summary

✅ 22 untouched

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out 🚀

@github-project-automation github-project-automation bot moved this from Fast Track to Reviewed in SCOUT Dec 23, 2025
@jonathan-eq jonathan-eq merged commit 7064211 into equinor:main Dec 29, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Dec 29, 2025
@scout-team-app
Copy link

Successfully created backport PR for version-18.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants