Skip to content

Enforce all ruff rules already passing#12524

Merged
berland merged 2 commits intoequinor:mainfrom
berland:ruff_implicit_passing
Dec 19, 2025
Merged

Enforce all ruff rules already passing#12524
berland merged 2 commits intoequinor:mainfrom
berland:ruff_implicit_passing

Conversation

@berland
Copy link
Contributor

@berland berland commented Dec 18, 2025

Issue
Resolves the possibility of a lot of ruff issues sneaking un-noticed into the codebase

Approach

  • Ask an AI to create a script to find all ruff rulesets that we currently pass but not enforce.
  • Fix the script.
  • Run the script.
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@berland berland self-assigned this Dec 18, 2025
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 18, 2025
@berland berland changed the title Ruff implicit passing Enforce all ruff rules already passing Dec 18, 2025
@berland berland added this to SCOUT Dec 18, 2025
@berland berland moved this to Fast Track in SCOUT Dec 18, 2025
@berland berland enabled auto-merge (rebase) December 18, 2025 17:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.65%. Comparing base (9aad2b7) to head (434ba26).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12524      +/-   ##
==========================================
- Coverage   90.67%   90.65%   -0.02%     
==========================================
  Files         431      431              
  Lines       29720    29720              
==========================================
- Hits        26948    26944       -4     
- Misses       2772     2776       +4     
Flag Coverage Δ
cli-tests 37.61% <ø> (ø)
gui-tests 68.76% <ø> (+0.03%) ⬆️
performance-and-unit-tests 74.15% <ø> (-0.02%) ⬇️
test 38.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #12524 will not alter performance

Comparing berland:ruff_implicit_passing (434ba26) with main (9aad2b7)

Summary

✅ 22 untouched

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:computer

@berland berland merged commit 19228a0 into equinor:main Dec 19, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from Fast Track to Reviewed in SCOUT Dec 19, 2025
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:maintenance Automatically categorise as maintenance change in release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants