Skip to content

Backport: Fix flaky test 'test_that_terminating_experiment_shows_a_confirmation…#12509

Merged
jonathan-eq merged 1 commit intoequinor:version-17.0from
jonathan-eq:backport
Dec 16, 2025
Merged

Backport: Fix flaky test 'test_that_terminating_experiment_shows_a_confirmation…#12509
jonathan-eq merged 1 commit intoequinor:version-17.0from
jonathan-eq:backport

Conversation

@jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Dec 15, 2025

…_dialog'

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq changed the title Fix flaky test 'test_that_terminating_experiment_shows_a_confirmation… Backport: Fix flaky test 'test_that_terminating_experiment_shows_a_confirmation… Dec 15, 2025
@jonathan-eq jonathan-eq added the release-notes:flaky-test-fix PR fixes a flaky test label Dec 15, 2025
@jonathan-eq jonathan-eq moved this to Ready for Review in SCOUT Dec 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.55%. Comparing base (d22c5da) to head (062047a).

Additional details and impacted files
@@              Coverage Diff              @@
##           version-17.0   #12509   +/-   ##
=============================================
  Coverage         90.55%   90.55%           
=============================================
  Files               435      435           
  Lines             29094    29094           
=============================================
  Hits              26345    26345           
  Misses             2749     2749           
Flag Coverage Δ
cli-tests 37.62% <ø> (ø)
gui-tests 68.98% <ø> (ø)
performance-and-unit-tests 73.98% <ø> (ø)
test 38.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging #12509 will not alter performance

Comparing jonathan-eq:backport (062047a) with main (8680a82)1

Summary

✅ 22 untouched

Footnotes

  1. No successful run was found on version-17.0 (d22c5da) during the generation of this report, so main (8680a82) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Dec 16, 2025
@jonathan-eq jonathan-eq merged commit c97dc42 into equinor:version-17.0 Dec 16, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Dec 16, 2025
@jonathan-eq jonathan-eq deleted the backport branch December 16, 2025 09:00
@scout-team-app
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants