Skip to content

Update release highlights on parameters.json format#12507

Merged
xjules merged 1 commit intoequinor:mainfrom
xjules:docs_parameter_json
Dec 16, 2025
Merged

Update release highlights on parameters.json format#12507
xjules merged 1 commit intoequinor:mainfrom
xjules:docs_parameter_json

Conversation

@xjules
Copy link
Contributor

@xjules xjules commented Dec 15, 2025

Issue
Resolves #12453

Approach
Update release highlights

(Screenshot of new behavior in GUI if applicable)
image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@xjules xjules self-assigned this Dec 15, 2025
@xjules xjules requested a review from oyvindeide December 15, 2025 11:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.62%. Comparing base (4d46eaf) to head (d250a2e).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12507      +/-   ##
==========================================
- Coverage   90.67%   90.62%   -0.06%     
==========================================
  Files         434      430       -4     
  Lines       29570    29481      -89     
==========================================
- Hits        26814    26717      -97     
- Misses       2756     2764       +8     
Flag Coverage Δ
cli-tests 37.87% <ø> (+0.15%) ⬆️
gui-tests 68.61% <ø> (-0.37%) ⬇️
performance-and-unit-tests 74.35% <ø> (+0.04%) ⬆️
test 38.58% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging #12507 will not alter performance

Comparing xjules:docs_parameter_json (956b168) with main (4d46eaf)

Summary

✅ 22 untouched

@jonathan-eq
Copy link
Contributor

I think this should be fine @JHolba

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

################################

We’ve changed the format of the parameters.json file located in the runpath of each
realization. The new format is more compact and easier to read. The groups have been dropped, so
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That the new format is easier to read is quite subjective, I would just emphasize that the group concept has been drop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That the new format is easier to read is quite subjective, I would just emphasize that the group concept has been drop.

Correct. I meant more once we introduce new attributes (distributions, etc. ). So yes, I can drop it.

This introduces highlted changes to ert==18.0 wrt to new
parameters.json format where the groups have been droped from the file.
@xjules xjules force-pushed the docs_parameter_json branch from 956b168 to d250a2e Compare December 16, 2025 14:16
@xjules xjules enabled auto-merge (rebase) December 16, 2025 14:25
@xjules xjules merged commit 0273766 into equinor:main Dec 16, 2025
33 of 34 checks passed
@xjules xjules deleted the docs_parameter_json branch December 16, 2025 14:31
@scout-team-app
Copy link

Successfully created backport PR for version-18.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update release_notes highlights about parameters.json

4 participants