Add parameter tab to gui#12503
Conversation
94dcd44 to
ef61d85
Compare
ef61d85 to
0098fc7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12503 +/- ##
==========================================
+ Coverage 90.55% 90.68% +0.13%
==========================================
Files 431 431
Lines 29123 29606 +483
==========================================
+ Hits 26372 26848 +476
- Misses 2751 2758 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #12503 will not alter performanceComparing Summary
|
|
How does it look when you have a design matrix with 500 parameters and 200 realz? |
Probably not very nice. Where can i find a config / example that contains ⬆️ |
| self._export_button.setEnabled(True) | ||
|
|
||
| file_path = self._file_path_edit.text().strip() | ||
| if not file_path or file_path.endswith(("/", "\\")): |
There was a problem hiding this comment.
I guess this can be done via:
if file_path or file_path.is_dir():
I have sent you an example via slack. |
src/ert/gui/tools/manage_experiments/export_parameters_dialog.py
Outdated
Show resolved
Hide resolved
|
|
06d4088 to
3e1b9fa
Compare
| from ert.storage import Storage | ||
|
|
||
|
|
||
| def test_that_export_writes_to_file_and_check_the_file_contents( |
There was a problem hiding this comment.
I think it should be file_content.
xjules
left a comment
There was a problem hiding this comment.
There was just a grammar typo, but otherwise nice! 🚀
3e1b9fa to
245a7f8
Compare
245a7f8 to
2d6bc6a
Compare
* Add parameter tab with export functionality to the ensemble view.
* Add parameter tab with export functionality to the ensemble view.
Issue
Resolves #12423
With design matrix:
git rebase -i main --exec 'just rapid-tests')When applicable