Skip to content

Add parameter tab to gui#12503

Merged
frode-aarstad merged 2 commits intoequinor:mainfrom
frode-aarstad:add-parameter-tab-to-gui
Dec 17, 2025
Merged

Add parameter tab to gui#12503
frode-aarstad merged 2 commits intoequinor:mainfrom
frode-aarstad:add-parameter-tab-to-gui

Conversation

@frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Dec 15, 2025

Issue
Resolves #12423

image

With design matrix:

image
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@frode-aarstad frode-aarstad self-assigned this Dec 15, 2025
@frode-aarstad frode-aarstad added the release-notes:new-feature Automatically categorise as new feature in release notes label Dec 15, 2025
@frode-aarstad frode-aarstad force-pushed the add-parameter-tab-to-gui branch from 94dcd44 to ef61d85 Compare December 15, 2025 08:55
@frode-aarstad frode-aarstad force-pushed the add-parameter-tab-to-gui branch from ef61d85 to 0098fc7 Compare December 15, 2025 09:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 97.01493% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.68%. Comparing base (344e08b) to head (2d6bc6a).
⚠️ Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
...ols/manage_experiments/export_parameters_dialog.py 95.12% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12503      +/-   ##
==========================================
+ Coverage   90.55%   90.68%   +0.13%     
==========================================
  Files         431      431              
  Lines       29123    29606     +483     
==========================================
+ Hits        26372    26848     +476     
- Misses       2751     2758       +7     
Flag Coverage Δ
cli-tests 37.69% <2.98%> (-0.02%) ⬇️
gui-tests 68.76% <97.01%> (-0.57%) ⬇️
performance-and-unit-tests 74.14% <20.14%> (+0.10%) ⬆️
test 38.42% <1.49%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging #12503 will not alter performance

Comparing frode-aarstad:add-parameter-tab-to-gui (2d6bc6a) with main (0273766)

Summary

✅ 22 untouched

@xjules
Copy link
Contributor

xjules commented Dec 15, 2025

How does it look when you have a design matrix with 500 parameters and 200 realz?

@frode-aarstad
Copy link
Contributor Author

How does it look when you have a design matrix with 500 parameters and 200 realz?

Probably not very nice. Where can i find a config / example that contains ⬆️

self._export_button.setEnabled(True)

file_path = self._file_path_edit.text().strip()
if not file_path or file_path.endswith(("/", "\\")):
Copy link
Contributor

@xjules xjules Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this can be done via:
if file_path or file_path.is_dir():

@xjules
Copy link
Contributor

xjules commented Dec 15, 2025

How does it look when you have a design matrix with 500 parameters and 200 realz?

Probably not very nice. Where can i find a config / example that contains ⬆️

I have sent you an example via slack.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

@xjules
Copy link
Contributor

xjules commented Dec 16, 2025

I think you can include also backport to version-18.0 label
I have talked to @oyvindeide and we will do this as a new feature in next release together with removal of the old export utility.

@frode-aarstad frode-aarstad force-pushed the add-parameter-tab-to-gui branch 2 times, most recently from 06d4088 to 3e1b9fa Compare December 16, 2025 10:52
from ert.storage import Storage


def test_that_export_writes_to_file_and_check_the_file_contents(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be file_content.

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was just a grammar typo, but otherwise nice! 🚀

@frode-aarstad frode-aarstad force-pushed the add-parameter-tab-to-gui branch from 3e1b9fa to 245a7f8 Compare December 17, 2025 06:46
@frode-aarstad frode-aarstad force-pushed the add-parameter-tab-to-gui branch from 245a7f8 to 2d6bc6a Compare December 17, 2025 07:33
@frode-aarstad frode-aarstad merged commit b2b0eac into equinor:main Dec 17, 2025
34 checks passed
@frode-aarstad frode-aarstad deleted the add-parameter-tab-to-gui branch December 17, 2025 08:02
yngve-sk pushed a commit to yngve-sk/ert that referenced this pull request Dec 19, 2025
* Add parameter tab with export functionality to the ensemble view.
lucaeg pushed a commit to lucaeg/ert that referenced this pull request Jan 14, 2026
* Add parameter tab with export functionality to the ensemble view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:new-feature Automatically categorise as new feature in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement export parameters as csv into manage experiment panel

4 participants