Conversation
larsevj
commented
Dec 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12502 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 434 434
Lines 29570 29570
=======================================
Hits 26810 26810
Misses 2760 2760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3f8e44c to
db6cb26
Compare
|
New scikit-learn release changes results for enif update. Need to relax floating point precision from 11 to 5 to match to earlier version, alternative is to update snapshot based only on newer version, but would require more coordination with komodo etc. Not sure what is preferable? https://scikit-learn.org/stable/auto_examples/release_highlights/plot_release_highlights_1_8_0.html |
CodSpeed Performance ReportMerging #12502 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Pull request overview
This PR updates the uv lockfile with 36 dependency version bumps, adds 7 new dependencies (emcee, gstools, gstools-cython, hankel, meshio, mpmath, pyevtk), and makes a test modification. The updates include minor and patch version bumps across various packages including testing tools, data processing libraries, and observability instrumentation.
Key changes:
- Updates 36 existing dependencies to newer minor/patch versions
- Adds 7 new dependencies (primarily related to gstools for geostatistical tools)
- Reduces float precision in a snapshot test from 11 to 5 decimal places
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uv.lock | Updates dependency versions across the lockfile, including coverage, debugging tools, scientific computing libraries, and adds new geostatistical tool dependencies |
| tests/ert/ui_tests/cli/test_cli.py | Reduces float precision for CSV snapshot comparison from 11 to 5 decimal places |
| data, | ||
| ) | ||
| snapshot.assert_match(result.write_csv(float_precision=11), "enif_snapshot.csv") | ||
| snapshot.assert_match(result.write_csv(float_precision=5), "enif_snapshot.csv") |
There was a problem hiding this comment.
The float precision for CSV output has been reduced from 11 to 5 decimal places without explanation. This change appears unrelated to the stated purpose of updating the uv lockfile. If this change is intentional and necessary due to dependency updates affecting floating-point behavior, it should be documented in the commit message or PR description to explain why the reduced precision is acceptable and what prompted this change.
| snapshot.assert_match(result.write_csv(float_precision=5), "enif_snapshot.csv") | |
| snapshot.assert_match(result.write_csv(float_precision=12), "enif_snapshot.csv") |