[Backport version-17.0] Disregard unupdated parameters with EnIF#12497
Merged
yngve-sk merged 1 commit intoversion-17.0from Dec 15, 2025
Merged
[Backport version-17.0] Disregard unupdated parameters with EnIF#12497yngve-sk merged 1 commit intoversion-17.0from
yngve-sk merged 1 commit intoversion-17.0from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version-17.0 #12497 +/- ##
=============================================
Coverage 90.55% 90.55%
=============================================
Files 435 435
Lines 29093 29094 +1
=============================================
+ Hits 26344 26345 +1
Misses 2749 2749
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #12497 will not alter performanceComparing Summary
Footnotes |
yngve-sk
approved these changes
Dec 15, 2025
After some discussions, it has been decided that we will do this to make EnIF not crash when there are categorical variables. PS: This is theoretically wrong, as parameters may affect responses even if they are not updated. Example of this: Suppose we have one scalar parameter + 200 design matrix parameters, and the response is mainly affected by the design parameters. Now EnIF will overlook this and give a poor update. We should aim to first disregard categoricals, but eventually also somehow include them. (cherry picked from commit 8fc6e0e)
yngve-sk
force-pushed
the
backport-12388-to-version-17.0
branch
from
814f25c to
ed72b14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #12388 to
version-17.0.