Replace pytest-qt with QtTest fatal reporting & reduce test data size of slow model test#12496
Merged
eivindjahren merged 2 commits intoequinor:mainfrom Dec 12, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12496 +/- ##
==========================================
- Coverage 90.68% 90.66% -0.03%
==========================================
Files 434 434
Lines 29569 29570 +1
==========================================
- Hits 26816 26810 -6
- Misses 2753 2760 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #12496 will not alter performanceComparing Summary
|
This ends up calling is_high_contrast_mode() and is_dark_mode() in a setting where there is no app so these need to check for that.
ea705ef to
e3fcd77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ends up calling is_high_contrast_mode() and is_dark_mode() in a setting where there is no app so these need to check for that.
Also reduces the test data of the model test. This test took about 3 minutes in CI, now it takes less than a second.
git rebase -i main --exec 'just rapid-tests')When applicable