Skip to content

Replace pytest-qt with QtTest fatal reporting & reduce test data size of slow model test#12496

Merged
eivindjahren merged 2 commits intoequinor:mainfrom
eivindjahren:use_same_qt_model_testing_mode
Dec 12, 2025
Merged

Replace pytest-qt with QtTest fatal reporting & reduce test data size of slow model test#12496
eivindjahren merged 2 commits intoequinor:mainfrom
eivindjahren:use_same_qt_model_testing_mode

Conversation

@eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Dec 12, 2025

This ends up calling is_high_contrast_mode() and is_dark_mode() in a setting where there is no app so these need to check for that.

Also reduces the test data of the model test. This test took about 3 minutes in CI, now it takes less than a second.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@eivindjahren eivindjahren added the release-notes:build-system PR containing only build system changes label Dec 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (bd61fdf) to head (e3fcd77).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12496      +/-   ##
==========================================
- Coverage   90.68%   90.66%   -0.03%     
==========================================
  Files         434      434              
  Lines       29569    29570       +1     
==========================================
- Hits        26816    26810       -6     
- Misses       2753     2760       +7     
Flag Coverage Δ
cli-tests 37.71% <0.00%> (+<0.01%) ⬆️
gui-tests 68.95% <100.00%> (-0.06%) ⬇️
performance-and-unit-tests 74.30% <100.00%> (+0.03%) ⬆️
test 38.43% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 12, 2025

CodSpeed Performance Report

Merging #12496 will not alter performance

Comparing eivindjahren:use_same_qt_model_testing_mode (e3fcd77) with main (8fc6e0e)

Summary

✅ 22 untouched

@eivindjahren eivindjahren changed the title Replace pytest-qt with QtTest fatal reporting Replace pytest-qt with QtTest fatal reporting & reduce size of long model test Dec 12, 2025
@eivindjahren eivindjahren changed the title Replace pytest-qt with QtTest fatal reporting & reduce size of long model test Replace pytest-qt with QtTest fatal reporting & reduce test data size of slow model test Dec 12, 2025
This ends up calling is_high_contrast_mode() and
is_dark_mode() in a setting where there is no app
so these need to check for that.
@eivindjahren eivindjahren force-pushed the use_same_qt_model_testing_mode branch from ea705ef to e3fcd77 Compare December 12, 2025 12:43
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@eivindjahren eivindjahren merged commit d6e78fb into equinor:main Dec 12, 2025
34 checks passed
@eivindjahren eivindjahren deleted the use_same_qt_model_testing_mode branch December 12, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:build-system PR containing only build system changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants