Remove parameter metadata

[xjules]

Issue
Resolves #12418

Make use that all parameters are pydantic basemodel now.
(Screenshot of new behavior in GUI if applicable)

It might require to change webviz-ert dark storage API

• PR title captures the intent of the changes, and is fitting for release notes.
• Added appropriate release note label
• Commit history is consistent and clean, in line with the contribution guidelines.
• Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

• When there are user facing changes: Updated documentation
• New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
• Large PR: Prepare changes in small commits for more convenient review
• Bug fix: Add regression test for the bug
• Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

[codecov-commenter]

Codecov Report

❌ Patch coverage is 65.95745% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.61%. Comparing base (c612499) to head (b3233c4).

Files with missing lines	Patch %	Lines
src/ert/storage/migration/to19.py	31.81%	15 Missing ⚠️
src/ert/dark_storage/endpoints/parameters.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12466      +/-   ##
==========================================
- Coverage   90.69%   90.61%   -0.09%     
==========================================
  Files         431      432       +1     
  Lines       29734    29738       +4     
==========================================
- Hits        26968    26947      -21     
- Misses       2766     2791      +25     

Flag	Coverage Δ
cli-tests	37.59% <21.27%> (-0.04%)	⬇️
gui-tests	68.72% <44.68%> (-0.04%)	⬇️
performance-and-unit-tests	74.13% <57.44%> (-0.07%)	⬇️
test	38.32% <19.14%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codspeed-hq]

CodSpeed Performance Report

Merging #12466 will not alter performance

_{Comparing xjules:rem_metadata_genkw (b3233c4) with main (c612499)}

Summary

✅ 22 untouched

[Copilot]

Pull request overview

This PR refactors parameter configuration handling by removing the ParameterMetadata class and making all parameter types use pydantic BaseModel directly with a dimensionality attribute. This simplifies the parameter configuration system while maintaining backward compatibility through storage migration.

Key Changes

• Removed ParameterMetadata class and replaced it with direct use of parameter configuration models
• Added dimensionality field directly to all parameter config classes (GenKwConfig, Field, SurfaceConfig)
• Created storage migration to19 to add dimensionality to existing parameter configurations

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/ert/config/parameter_config.py	Commented out ParameterMetadata class definition (should be removed entirely)
src/ert/config/gen_kw_config.py	Added dimensionality field (literal 1) and removed metadata property
src/ert/config/field.py	Added dimensionality field (literal 3) and removed metadata property
src/ert/config/surface_config.py	Added dimensionality field (literal 2) and removed metadata property
src/ert/config/ext_param_config.py	Removed metadata property
src/ert/config/__init__.py	Removed ParameterMetadata export
src/ert/storage/migration/to19.py	New migration to add dimensionality to existing parameters based on type
src/ert/storage/local_storage.py	Registered to19 migration
src/ert/dark_storage/endpoints/experiments.py	Changed from returning list of metadata to single config model_dump
src/ert/dark_storage/endpoints/parameters.py	Simplified parameter data fetching to use parameter name directly
src/ert/gui/tools/plot/plot_api.py	Updated to use parameter config instead of ParameterMetadata
src/ert/gui/tools/plot/plot_window.py	Updated to check dimensionality instead of data_origin metadata
tests/ert/unit_tests/storage/test_storage_migration.py	Added assertions to verify dimensionality after migration
tests/ert/unit_tests/storage/snapshots/...	Updated snapshots to include dimensionality field
tests/ert/unit_tests/run_models/snapshots/...	Updated experiment serialization snapshots with dimensionality
tests/ert/unit_tests/gui/tools/plot/test_plot_api.py	Updated tests to use GenKwConfig instead of ParameterMetadata
tests/ert/unit_tests/gui/tools/plot/conftest.py	Updated mock data to match new parameter structure
tests/ert/unit_tests/dark_storage/test_parameters.py	Removed test for group-based parameter access, simplified parameter lookup
tests/ert/unit_tests/dark_storage/test_http_endpoints.py	Updated tests to expect new parameter structure with full config

Comments suppressed due to low confidence (1)

src/ert/config/parameter_config.py:46

• This comment appears to contain commented-out code.

# class ParameterMetadata(BaseModel):
#     key: str
#     transformation: str | None
#     dimensionality: Literal[1, 2, 3] = 1
#     userdata: dict[str, Any]

[frode-aarstad]

Should there not be a test_to19.py for this ? Or is the migration to trivial?

[xjules]

Should there not be a test_to19.py for this ? Or is the migration to trivial?

Not sure. This is just adding a new attribute. Maybe I can make a simple one though

[frode-aarstad]

Looks good. Squash and merge 🎅🏻